Unverified Commit 90c5a6cc authored by WorldTeacher's avatar WorldTeacher
Browse files

fix(sync): improve user feedback in sync dialog for missing spine

parent 244dd7fb

.gitlab-ci.yml

+9 −3
Original line number Diff line number Diff line
@@ -54,9 +54,15 @@ run-tests: 
  coverage: '/TOTAL_COVERAGE=([0-9]+\.?[0-9]*%)/'

  before_script:

    - apk add --no-cache bash lua5.1 lua5.1-dev luarocks build-base unzip

    - luarocks --lua-version=5.1 install busted

    - luarocks --lua-version=5.1 install luacov

    - luarocks --lua-version=5.1 install luacov-cobertura

    - |

      LUAROCKS_BIN="$(command -v luarocks || command -v luarocks-5.1 || true)"

      if [ -z "$LUAROCKS_BIN" ]; then

        echo "ERROR: LuaRocks executable not found after installation"

        exit 1

      fi

      "$LUAROCKS_BIN" --lua-version=5.1 install busted

      "$LUAROCKS_BIN" --lua-version=5.1 install luacov

      "$LUAROCKS_BIN" --lua-version=5.1 install luacov-cobertura

  script:

    - bash run_tests.sh

  artifacts:

bookloresync.koplugin/main.lua

+6 −6
Original line number Diff line number Diff line
@@ -2197,13 +2197,13 @@ function BookloreSync:_fileDialogBookloreSync(file_path) 
                text     = _("Annotations"),

                callback = function()

                    UIManager:close(sync_dialog)

                    UIManager:show(InfoMessage:new{

                        text = _("Will only sync to webUI, not in book"),

                        timeout = 1.5,

                    })

                    UIManager:scheduleIn(1.5, function()

                    UIManager:show(ConfirmBox:new{

                        text = _("Will only sync to webUI, not in book, as spine is missing"),

                        ok_text = _("Continue"),

                        ok_callback = function()

                            self:fileDialogSyncAnnotations(file_path)

                    end)

                        end,

                    })

                end,

            }},

            {{